UI shell customization #2445
Open
UI shell customization #2445
+1,007
−223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| contrastMode={appBackgroundContrastMode} | ||
| sideNavBackgroundColor={ | ||
| componentProps?.sideNavProps?.mainBackgroundColor || | ||
| odysseyDesignTokens.HueNeutralWhite |
There was a problem hiding this comment.
opinion: should SideNav handle the fallback/default color internally rather than UiShell passing it?
There was a problem hiding this comment.
No strong feelings on that one. I can move the default to the provider
bryancunningham-okta
force-pushed
the
DES-6894-ui-shell-customization
branch
from
efcf358 to
7e477fb
Compare
benschell-okta
previously approved these changes
Dec 20, 2024
| @@ -153,7 +155,7 @@ export type UiShellContentProps = { | |||
| * If an error occurs, this will revert to only showing the app. | |||
| */ | |||
| const UiShellContent = ({ | |||
| appBackgroundContrastMode = "lowContrast", | |||
| // appBackgroundContrastMode = "lowContrast", | |||
There was a problem hiding this comment.
nit: probably just want to remove this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REPLACE_WITH_JIRA_TICKET_NUMBER
Summary
Testing & Screenshots